Skip to content

Commit d4db572

Browse files
xdarklightjbrun3t
authored andcommitted
clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't know the relation between this clock and RGMII Ethernet. It turns out that fclk_div2 is used as "timing adjustment clock" to generate the RX delay on the MAC side - which was enabled by u-boot on Odriod-C1. When using the RX delay on the PHY side or not using a RX delay at all then this clock can be disabled. Signed-off-by: Martin Blumenstingl <[email protected]> Signed-off-by: Jerome Brunet <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 2f1efa5 commit d4db572

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/clk/meson/meson8b.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -293,13 +293,6 @@ static struct clk_regmap meson8b_fclk_div2 = {
293293
&meson8b_fclk_div2_div.hw
294294
},
295295
.num_parents = 1,
296-
/*
297-
* FIXME: Ethernet with a RGMII PHYs is not working if
298-
* fclk_div2 is disabled. it is currently unclear why this
299-
* is. keep it enabled until the Ethernet driver knows how
300-
* to manage this clock.
301-
*/
302-
.flags = CLK_IS_CRITICAL,
303296
},
304297
};
305298

0 commit comments

Comments
 (0)