firmware: arm_scmi: Fix boolconv.cocci warnings

intel-lab-lkp · sudeep-holla · commit d4fda7ec1d2a · 2021-08-09T06:03:52.000+01:00
drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci Link: https://lore.kernel.org/r/20210807173127.GA43248@a24dbc127934 CC: Igor Skalkin <igor.skalkin@opensynergy.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/drivers/firmware/arm_scmi/virtio.c b/drivers/firmware/arm_scmi/virtio.c
@@ -222,7 +222,7 @@ static bool virtio_chan_available(struct device *dev, int idx)
 		return false;
 	}
 
-	return vioch && !vioch->cinfo ? true : false;
+	return vioch && !vioch->cinfo;
 }
 
 static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ static bool virtio_chan_available(struct device *dev, int idx)`
`222`	`222`	`return false;`
`223`	`223`	`}`
`224`	`224`
`225`		`- return vioch && !vioch->cinfo ? true : false;`
	`225`	`+ return vioch && !vioch->cinfo;`
`226`	`226`	`}`
`227`	`227`
`228`	`228`	`static int virtio_chan_setup(struct scmi_chan_info cinfo, struct device dev,`