Skip to content

Commit d59d844

Browse files
qzhuo2aegl
authored andcommitted
EDAC/ie31200: Fix the size of EDAC_MC_LAYER_CHIP_SELECT layer
The EDAC_MC_LAYER_CHIP_SELECT layer pertains to the rank, not the DIMM. Fix its size to reflect the number of ranks instead of the number of DIMMs. Also delete the unused macros IE31200_{DIMMS,RANKS}. Fixes: 7ee40b8 ("ie31200_edac: Introduce the driver") Signed-off-by: Qiuxu Zhuo <[email protected]> Signed-off-by: Tony Luck <[email protected]> Tested-by: Gary Wang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent d9207cf commit d59d844

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/edac/ie31200_edac.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,6 @@
9494
(((did) & PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK) == \
9595
PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK))
9696

97-
#define IE31200_DIMMS 4
98-
#define IE31200_RANKS 8
9997
#define IE31200_RANKS_PER_CHANNEL 4
10098
#define IE31200_DIMMS_PER_CHANNEL 2
10199
#define IE31200_CHANNELS 2
@@ -428,7 +426,7 @@ static int ie31200_probe1(struct pci_dev *pdev, int dev_idx)
428426

429427
nr_channels = how_many_channels(pdev);
430428
layers[0].type = EDAC_MC_LAYER_CHIP_SELECT;
431-
layers[0].size = IE31200_DIMMS;
429+
layers[0].size = IE31200_RANKS_PER_CHANNEL;
432430
layers[0].is_virt_csrow = true;
433431
layers[1].type = EDAC_MC_LAYER_CHANNEL;
434432
layers[1].size = nr_channels;

0 commit comments

Comments
 (0)