Skip to content

Commit d5cf50d

Browse files
committed
Kconfig: add some hidden tabs on purpose
Commit d96c360 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry") removed a hidden tab because it apparently showed breakage in some third-party kernel config parsing tool. It wasn't clear what tool it was, but let's make sure it gets fixed. Because if you can't parse tabs as whitespace, you should not be parsing the kernel Kconfig files. In fact, let's make such breakage more obvious than some esoteric ftrace record size option. If you can't parse tabs, you can't have page sizes. Yes, tab-vs-space confusion is sadly a traditional Unix thing, and 'make' is famous for being broken in this regard. But no, that does not mean that it's ok. I'd add more random tabs to our Kconfig files, but I don't want to make things uglier than necessary. But it *might* bbe necessary if it turns out we see more of this kind of silly tooling. Fixes: d96c360 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry") Link: https://lore.kernel.org/lkml/CAHk-=wj-hLLN_t_m5OL4dXLaxvXKy_axuoJYXif7iczbfgAevQ@mail.gmail.com/ Signed-off-by: Linus Torvalds <[email protected]>
1 parent 5939d45 commit d5cf50d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

arch/Kconfig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,12 +1172,12 @@ config PAGE_SIZE_LESS_THAN_256KB
11721172

11731173
config PAGE_SHIFT
11741174
int
1175-
default 12 if PAGE_SIZE_4KB
1176-
default 13 if PAGE_SIZE_8KB
1177-
default 14 if PAGE_SIZE_16KB
1178-
default 15 if PAGE_SIZE_32KB
1179-
default 16 if PAGE_SIZE_64KB
1180-
default 18 if PAGE_SIZE_256KB
1175+
default 12 if PAGE_SIZE_4KB
1176+
default 13 if PAGE_SIZE_8KB
1177+
default 14 if PAGE_SIZE_16KB
1178+
default 15 if PAGE_SIZE_32KB
1179+
default 16 if PAGE_SIZE_64KB
1180+
default 18 if PAGE_SIZE_256KB
11811181

11821182
# This allows to use a set of generic functions to determine mmap base
11831183
# address by giving priority to top-down scheme only if the process

0 commit comments

Comments
 (0)