net: ethernet: microchip: lan743x: Fix driver crash when lan743x_pm_resume fails

microchip1 · davem330 · commit d6423d2ec39c · 2021-10-24T13:37:48.000+01:00
The driver needs to clean up and return when the initialization fails on resume. Fixes: 23f0703 ("lan743x: Add main source files for new lan743x driver") Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3019,6 +3019,8 @@ static int lan743x_pm_resume(struct device *dev)
 	if (ret) {
 		netif_err(adapter, probe, adapter->netdev,
 			  "lan743x_hardware_init returned %d\n", ret);
+		lan743x_pci_cleanup(adapter);
+		return ret;
 	}
 
 	/* open netdev when netdev is at running state while resume.

Original file line number	Diff line number	Diff line change
`@@ -3019,6 +3019,8 @@ static int lan743x_pm_resume(struct device *dev)`
`3019`	`3019`	`if (ret) {`
`3020`	`3020`	`netif_err(adapter, probe, adapter->netdev,`
`3021`	`3021`	`"lan743x_hardware_init returned %d\n", ret);`
	`3022`	`+ lan743x_pci_cleanup(adapter);`
	`3023`	`+ return ret;`
`3022`	`3024`	`}`
`3023`	`3025`
`3024`	`3026`	`/* open netdev when netdev is at running state while resume.`