Skip to content

Commit d679071

Browse files
jhovoldandersson
authored andcommitted
firmware: qcom: scm: suppress download mode error
Stop spamming the logs with errors about missing mechanism for setting the so called download (or dump) mode for users that have not requested that feature to be enabled in the first place. This avoids the follow error being logged on boot as well as on shutdown when the feature it not available and download mode has not been enabled on the kernel command line: qcom_scm firmware:scm: No available mechanism for setting download mode Fixes: 79cb2cb ("firmware: qcom: scm: Disable SDI and write no dump to dump mode") Fixes: 781d32d ("firmware: qcom_scm: Clear download bit during reboot") Cc: Mukesh Ojha <[email protected]> Cc: [email protected] # 6.4 Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Mukesh Ojha <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent e694d2b commit d679071

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/firmware/qcom/qcom_scm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ static void qcom_scm_set_download_mode(u32 dload_mode)
545545
} else if (__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_BOOT,
546546
QCOM_SCM_BOOT_SET_DLOAD_MODE)) {
547547
ret = __qcom_scm_set_dload_mode(__scm->dev, !!dload_mode);
548-
} else {
548+
} else if (dload_mode) {
549549
dev_err(__scm->dev,
550550
"No available mechanism for setting download mode\n");
551551
}

0 commit comments

Comments
 (0)