Skip to content

Commit d6bb59a

Browse files
author
Matthew Wilcox (Oracle)
committed
iomap: Create large folios in the buffered write path
Use the size of the write as a hint for the size of the folio to create. Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]>
1 parent 4f66170 commit d6bb59a

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

fs/gfs2/bmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,7 @@ gfs2_iomap_get_folio(struct iomap_iter *iter, loff_t pos, unsigned len)
971971
if (status)
972972
return ERR_PTR(status);
973973

974-
folio = iomap_get_folio(iter, pos);
974+
folio = iomap_get_folio(iter, pos, len);
975975
if (IS_ERR(folio))
976976
gfs2_trans_end(sdp);
977977
return folio;

fs/iomap/buffered-io.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,16 +461,18 @@ EXPORT_SYMBOL_GPL(iomap_is_partially_uptodate);
461461
* iomap_get_folio - get a folio reference for writing
462462
* @iter: iteration structure
463463
* @pos: start offset of write
464+
* @len: Suggested size of folio to create.
464465
*
465466
* Returns a locked reference to the folio at @pos, or an error pointer if the
466467
* folio could not be obtained.
467468
*/
468-
struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos)
469+
struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len)
469470
{
470471
fgf_t fgp = FGP_WRITEBEGIN | FGP_NOFS;
471472

472473
if (iter->flags & IOMAP_NOWAIT)
473474
fgp |= FGP_NOWAIT;
475+
fgp |= fgf_set_order(len);
474476

475477
return __filemap_get_folio(iter->inode->i_mapping, pos >> PAGE_SHIFT,
476478
fgp, mapping_gfp_mask(iter->inode->i_mapping));
@@ -597,7 +599,7 @@ static struct folio *__iomap_get_folio(struct iomap_iter *iter, loff_t pos,
597599
if (folio_ops && folio_ops->get_folio)
598600
return folio_ops->get_folio(iter, pos, len);
599601
else
600-
return iomap_get_folio(iter, pos);
602+
return iomap_get_folio(iter, pos, len);
601603
}
602604

603605
static void __iomap_put_folio(struct iomap_iter *iter, loff_t pos, size_t ret,

include/linux/iomap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ int iomap_file_buffered_write_punch_delalloc(struct inode *inode,
261261
int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops);
262262
void iomap_readahead(struct readahead_control *, const struct iomap_ops *ops);
263263
bool iomap_is_partially_uptodate(struct folio *, size_t from, size_t count);
264-
struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos);
264+
struct folio *iomap_get_folio(struct iomap_iter *iter, loff_t pos, size_t len);
265265
bool iomap_release_folio(struct folio *folio, gfp_t gfp_flags);
266266
void iomap_invalidate_folio(struct folio *folio, size_t offset, size_t len);
267267
int iomap_file_unshare(struct inode *inode, loff_t pos, loff_t len,

0 commit comments

Comments
 (0)