Skip to content

Commit d72e0ff

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Change the domid to iova_region_id
Prepare for adding bankid, also no functional change. In the previous SoC, each a iova_region is a domain; In the multi-banks case, each a bank is a domain, then the original function name "mtk_iommu_get_domain_id" is not proper. Use "iova_region_id" instead of "domain_id". Signed-off-by: Yong Wu <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Reviewed-by: Matthias Brugger <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Joerg Roedel <[email protected]>
1 parent e24453e commit d72e0ff

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

drivers/iommu/mtk_iommu.c

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -467,8 +467,8 @@ static irqreturn_t mtk_iommu_isr(int irq, void *dev_id)
467467
return IRQ_HANDLED;
468468
}
469469

470-
static int mtk_iommu_get_domain_id(struct device *dev,
471-
const struct mtk_iommu_plat_data *plat_data)
470+
static int mtk_iommu_get_iova_region_id(struct device *dev,
471+
const struct mtk_iommu_plat_data *plat_data)
472472
{
473473
const struct mtk_iommu_iova_region *rgn = plat_data->iova_region;
474474
const struct bus_dma_region *dma_rgn = dev->dma_range_map;
@@ -498,7 +498,7 @@ static int mtk_iommu_get_domain_id(struct device *dev,
498498
}
499499

500500
static int mtk_iommu_config(struct mtk_iommu_data *data, struct device *dev,
501-
bool enable, unsigned int domid)
501+
bool enable, unsigned int regionid)
502502
{
503503
struct mtk_smi_larb_iommu *larb_mmu;
504504
unsigned int larbid, portid;
@@ -514,12 +514,12 @@ static int mtk_iommu_config(struct mtk_iommu_data *data, struct device *dev,
514514
if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
515515
larb_mmu = &data->larb_imu[larbid];
516516

517-
region = data->plat_data->iova_region + domid;
517+
region = data->plat_data->iova_region + regionid;
518518
larb_mmu->bank[portid] = upper_32_bits(region->iova_base);
519519

520-
dev_dbg(dev, "%s iommu for larb(%s) port %d dom %d bank %d.\n",
520+
dev_dbg(dev, "%s iommu for larb(%s) port %d region %d rgn-bank %d.\n",
521521
enable ? "enable" : "disable", dev_name(larb_mmu->dev),
522-
portid, domid, larb_mmu->bank[portid]);
522+
portid, regionid, larb_mmu->bank[portid]);
523523

524524
if (enable)
525525
larb_mmu->mmu |= MTK_SMI_MMU_EN(portid);
@@ -545,7 +545,7 @@ static int mtk_iommu_config(struct mtk_iommu_data *data, struct device *dev,
545545

546546
static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom,
547547
struct mtk_iommu_data *data,
548-
unsigned int domid)
548+
unsigned int region_id)
549549
{
550550
const struct mtk_iommu_iova_region *region;
551551
struct mtk_iommu_domain *m4u_dom;
@@ -584,7 +584,7 @@ static int mtk_iommu_domain_finalise(struct mtk_iommu_domain *dom,
584584

585585
update_iova_region:
586586
/* Update the iova region for this domain */
587-
region = data->plat_data->iova_region + domid;
587+
region = data->plat_data->iova_region + region_id;
588588
dom->domain.geometry.aperture_start = region->iova_base;
589589
dom->domain.geometry.aperture_end = region->iova_base + region->size - 1;
590590
dom->domain.geometry.force_aperture = true;
@@ -620,18 +620,18 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain,
620620
struct device *m4udev = data->dev;
621621
struct mtk_iommu_bank_data *bank;
622622
unsigned int bankid = 0;
623-
int ret, domid;
623+
int ret, region_id;
624624

625-
domid = mtk_iommu_get_domain_id(dev, data->plat_data);
626-
if (domid < 0)
627-
return domid;
625+
region_id = mtk_iommu_get_iova_region_id(dev, data->plat_data);
626+
if (region_id < 0)
627+
return region_id;
628628

629629
mutex_lock(&dom->mutex);
630630
if (!dom->bank) {
631631
/* Data is in the frstdata in sharing pgtable case. */
632632
frstdata = mtk_iommu_get_frst_data(hw_list);
633633

634-
ret = mtk_iommu_domain_finalise(dom, frstdata, domid);
634+
ret = mtk_iommu_domain_finalise(dom, frstdata, region_id);
635635
if (ret) {
636636
mutex_unlock(&dom->mutex);
637637
return -ENODEV;
@@ -662,7 +662,7 @@ static int mtk_iommu_attach_device(struct iommu_domain *domain,
662662
}
663663
mutex_unlock(&data->mutex);
664664

665-
return mtk_iommu_config(data, dev, true, domid);
665+
return mtk_iommu_config(data, dev, true, region_id);
666666

667667
err_unlock:
668668
mutex_unlock(&data->mutex);
@@ -802,22 +802,22 @@ static struct iommu_group *mtk_iommu_device_group(struct device *dev)
802802
struct mtk_iommu_data *c_data = dev_iommu_priv_get(dev), *data;
803803
struct list_head *hw_list = c_data->hw_list;
804804
struct iommu_group *group;
805-
int domid;
805+
int regionid;
806806

807807
data = mtk_iommu_get_frst_data(hw_list);
808808
if (!data)
809809
return ERR_PTR(-ENODEV);
810810

811-
domid = mtk_iommu_get_domain_id(dev, data->plat_data);
812-
if (domid < 0)
813-
return ERR_PTR(domid);
811+
regionid = mtk_iommu_get_iova_region_id(dev, data->plat_data);
812+
if (regionid < 0)
813+
return ERR_PTR(regionid);
814814

815815
mutex_lock(&data->mutex);
816-
group = data->m4u_group[domid];
816+
group = data->m4u_group[regionid];
817817
if (!group) {
818818
group = iommu_group_alloc();
819819
if (!IS_ERR(group))
820-
data->m4u_group[domid] = group;
820+
data->m4u_group[regionid] = group;
821821
} else {
822822
iommu_group_ref_get(group);
823823
}
@@ -851,14 +851,14 @@ static void mtk_iommu_get_resv_regions(struct device *dev,
851851
struct list_head *head)
852852
{
853853
struct mtk_iommu_data *data = dev_iommu_priv_get(dev);
854-
unsigned int domid = mtk_iommu_get_domain_id(dev, data->plat_data), i;
854+
unsigned int regionid = mtk_iommu_get_iova_region_id(dev, data->plat_data), i;
855855
const struct mtk_iommu_iova_region *resv, *curdom;
856856
struct iommu_resv_region *region;
857857
int prot = IOMMU_WRITE | IOMMU_READ;
858858

859-
if ((int)domid < 0)
859+
if ((int)regionid < 0)
860860
return;
861-
curdom = data->plat_data->iova_region + domid;
861+
curdom = data->plat_data->iova_region + regionid;
862862
for (i = 0; i < data->plat_data->iova_region_nr; i++) {
863863
resv = data->plat_data->iova_region + i;
864864

0 commit comments

Comments
 (0)