Skip to content

Commit d735bab

Browse files
jlelliPeter Zijlstra
authored andcommitted
sched/topology: Remove redundant dl_clear_root_domain call
We completely clean and restore root domains bandwidth accounting after every root domains change, so the dl_clear_root_domain() call in partition_sched_domains_locked() is redundant. Remove it. Signed-off-by: Juri Lelli <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Reviewed-by: Waiman Long <[email protected]> Reviewed-by: Shrikanth Hegde <[email protected]> Reviewed-by: Valentin Schneider <[email protected]> Reviewed-by: Dietmar Eggemann <[email protected]> Tested-by: Waiman Long <[email protected]> Tested-by: Jon Hunter <[email protected]> Tested-by: Dietmar Eggemann <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 2ff899e commit d735bab

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

kernel/sched/topology.c

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2720,21 +2720,8 @@ void partition_sched_domains_locked(int ndoms_new, cpumask_var_t doms_new[],
27202720
for (i = 0; i < ndoms_cur; i++) {
27212721
for (j = 0; j < n && !new_topology; j++) {
27222722
if (cpumask_equal(doms_cur[i], doms_new[j]) &&
2723-
dattrs_equal(dattr_cur, i, dattr_new, j)) {
2724-
struct root_domain *rd;
2725-
2726-
/*
2727-
* This domain won't be destroyed and as such
2728-
* its dl_bw->total_bw needs to be cleared.
2729-
* Tasks contribution will be then recomputed
2730-
* in function dl_update_tasks_root_domain(),
2731-
* dl_servers contribution in function
2732-
* dl_restore_server_root_domain().
2733-
*/
2734-
rd = cpu_rq(cpumask_any(doms_cur[i]))->rd;
2735-
dl_clear_root_domain(rd);
2723+
dattrs_equal(dattr_cur, i, dattr_new, j))
27362724
goto match1;
2737-
}
27382725
}
27392726
/* No match - a current sched domain not in new doms_new[] */
27402727
detach_destroy_domains(doms_cur[i]);

0 commit comments

Comments
 (0)