Skip to content

Commit d74b15d

Browse files
committed
Merge tag 'libnvdimm-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
Pull libnvdimm updates from Dan Williams: "Small collection of cleanups to rework usage of ->queuedata and the GUID api" * tag 'libnvdimm-for-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm: nvdimm/pmem: stop using ->queuedata nvdimm/btt: stop using ->queuedata nvdimm/blk: stop using ->queuedata libnvdimm: Replace guid_copy() with import_guid() where it makes sense
2 parents 298ce0f + 6ec26b8 commit d74b15d

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

drivers/acpi/nfit/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2293,7 +2293,7 @@ static int acpi_nfit_init_interleave_set(struct acpi_nfit_desc *acpi_desc,
22932293
nd_set = devm_kzalloc(dev, sizeof(*nd_set), GFP_KERNEL);
22942294
if (!nd_set)
22952295
return -ENOMEM;
2296-
guid_copy(&nd_set->type_guid, (guid_t *) spa->range_guid);
2296+
import_guid(&nd_set->type_guid, spa->range_guid);
22972297

22982298
info = devm_kzalloc(dev, sizeof_nfit_set_info(nr), GFP_KERNEL);
22992299
if (!info)

drivers/nvdimm/blk.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ static int nsblk_do_bvec(struct nd_namespace_blk *nsblk,
165165
static blk_qc_t nd_blk_make_request(struct request_queue *q, struct bio *bio)
166166
{
167167
struct bio_integrity_payload *bip;
168-
struct nd_namespace_blk *nsblk;
168+
struct nd_namespace_blk *nsblk = bio->bi_disk->private_data;
169169
struct bvec_iter iter;
170170
unsigned long start;
171171
struct bio_vec bvec;
@@ -176,7 +176,6 @@ static blk_qc_t nd_blk_make_request(struct request_queue *q, struct bio *bio)
176176
return BLK_QC_T_NONE;
177177

178178
bip = bio_integrity(bio);
179-
nsblk = q->queuedata;
180179
rw = bio_data_dir(bio);
181180
do_acct = blk_queue_io_stat(bio->bi_disk->queue);
182181
if (do_acct)
@@ -260,7 +259,6 @@ static int nsblk_attach_disk(struct nd_namespace_blk *nsblk)
260259
blk_queue_max_hw_sectors(q, UINT_MAX);
261260
blk_queue_logical_block_size(q, nsblk_sector_size(nsblk));
262261
blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
263-
q->queuedata = nsblk;
264262

265263
disk = alloc_disk(0);
266264
if (!disk)
@@ -270,6 +268,7 @@ static int nsblk_attach_disk(struct nd_namespace_blk *nsblk)
270268
disk->fops = &nd_blk_fops;
271269
disk->queue = q;
272270
disk->flags = GENHD_FL_EXT_DEVT;
271+
disk->private_data = nsblk;
273272
nvdimm_namespace_disk_name(&nsblk->common, disk->disk_name);
274273

275274
if (devm_add_action_or_reset(dev, nd_blk_release_disk, disk))

drivers/nvdimm/btt.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,7 +1442,7 @@ static int btt_do_bvec(struct btt *btt, struct bio_integrity_payload *bip,
14421442
static blk_qc_t btt_make_request(struct request_queue *q, struct bio *bio)
14431443
{
14441444
struct bio_integrity_payload *bip = bio_integrity(bio);
1445-
struct btt *btt = q->queuedata;
1445+
struct btt *btt = bio->bi_disk->private_data;
14461446
struct bvec_iter iter;
14471447
unsigned long start;
14481448
struct bio_vec bvec;
@@ -1545,7 +1545,6 @@ static int btt_blk_init(struct btt *btt)
15451545
blk_queue_logical_block_size(btt->btt_queue, btt->sector_size);
15461546
blk_queue_max_hw_sectors(btt->btt_queue, UINT_MAX);
15471547
blk_queue_flag_set(QUEUE_FLAG_NONROT, btt->btt_queue);
1548-
btt->btt_queue->queuedata = btt;
15491548

15501549
if (btt_meta_size(btt)) {
15511550
int rc = nd_integrity_init(btt->btt_disk, btt_meta_size(btt));

drivers/nvdimm/pmem.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ static blk_qc_t pmem_make_request(struct request_queue *q, struct bio *bio)
197197
unsigned long start;
198198
struct bio_vec bvec;
199199
struct bvec_iter iter;
200-
struct pmem_device *pmem = q->queuedata;
200+
struct pmem_device *pmem = bio->bi_disk->private_data;
201201
struct nd_region *nd_region = to_region(pmem);
202202

203203
if (bio->bi_opf & REQ_PREFLUSH)
@@ -234,7 +234,7 @@ static blk_qc_t pmem_make_request(struct request_queue *q, struct bio *bio)
234234
static int pmem_rw_page(struct block_device *bdev, sector_t sector,
235235
struct page *page, unsigned int op)
236236
{
237-
struct pmem_device *pmem = bdev->bd_queue->queuedata;
237+
struct pmem_device *pmem = bdev->bd_disk->private_data;
238238
blk_status_t rc;
239239

240240
if (op_is_write(op))
@@ -467,7 +467,6 @@ static int pmem_attach_disk(struct device *dev,
467467
blk_queue_flag_set(QUEUE_FLAG_NONROT, q);
468468
if (pmem->pfn_flags & PFN_MAP)
469469
blk_queue_flag_set(QUEUE_FLAG_DAX, q);
470-
q->queuedata = pmem;
471470

472471
disk = alloc_disk_node(0, nid);
473472
if (!disk)
@@ -477,6 +476,7 @@ static int pmem_attach_disk(struct device *dev,
477476
disk->fops = &pmem_fops;
478477
disk->queue = q;
479478
disk->flags = GENHD_FL_EXT_DEVT;
479+
disk->private_data = pmem;
480480
disk->queue->backing_dev_info->capabilities |= BDI_CAP_SYNCHRONOUS_IO;
481481
nvdimm_namespace_disk_name(ndns, disk->disk_name);
482482
set_capacity(disk, (pmem->size - pmem->pfn_pad - pmem->data_offset)

0 commit comments

Comments
 (0)