Skip to content

Commit d781840

Browse files
liuhangbindavem330
authored andcommitted
selftests: udpgro: no need to load xdp for gro
After commit d7db777 ("net: veth: do not manipulate GRO when using XDP"), there is no need to load XDP program to enable GRO. On the other hand, the current test is failed due to loading the XDP program. e.g. # selftests: net: udpgro.sh # ipv4 # no GRO ok # no GRO chk cmsg ok # GRO ./udpgso_bench_rx: recv: bad packet len, got 1472, expected 14720 # # failed [...] # bad GRO lookup ok # multiple GRO socks ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520 # # ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520 # # failed ok 1 selftests: net: udpgro.sh After fix, all the test passed. # ./udpgro.sh ipv4 no GRO ok [...] multiple GRO socks ok Fixes: d7db777 ("net: veth: do not manipulate GRO when using XDP") Reported-by: Yi Chen <[email protected]> Closes: https://issues.redhat.com/browse/RHEL-53858 Reviewed-by: Toke Høiland-Jørgensen <[email protected]> Acked-by: Paolo Abeni <[email protected]> Signed-off-by: Hangbin Liu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7167395 commit d781840

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

tools/testing/selftests/net/udpgro.sh

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ source net_helper.sh
77

88
readonly PEER_NS="ns-peer-$(mktemp -u XXXXXX)"
99

10-
BPF_FILE="xdp_dummy.bpf.o"
11-
1210
# set global exit status, but never reset nonzero one.
1311
check_err()
1412
{
@@ -38,7 +36,7 @@ cfg_veth() {
3836
ip -netns "${PEER_NS}" addr add dev veth1 192.168.1.1/24
3937
ip -netns "${PEER_NS}" addr add dev veth1 2001:db8::1/64 nodad
4038
ip -netns "${PEER_NS}" link set dev veth1 up
41-
ip -n "${PEER_NS}" link set veth1 xdp object ${BPF_FILE} section xdp
39+
ip netns exec "${PEER_NS}" ethtool -K veth1 gro on
4240
}
4341

4442
run_one() {
@@ -206,11 +204,6 @@ run_all() {
206204
return $ret
207205
}
208206

209-
if [ ! -f ${BPF_FILE} ]; then
210-
echo "Missing ${BPF_FILE}. Run 'make' first"
211-
exit -1
212-
fi
213-
214207
if [[ $# -eq 0 ]]; then
215208
run_all
216209
elif [[ $1 == "__subprocess" ]]; then

0 commit comments

Comments
 (0)