Skip to content

Commit d7aa294

Browse files
committed
accel/habanalabs: remove unused asic functions
asic_dma_{un}map_single() asic-specific functions are no longer called from the common code, so delete these functions. In addition, delete the gaudi2 implementation as they are also not called. Signed-off-by: Oded Gabbay <[email protected]> Reviewed-by: Ofir Bitton <[email protected]>
1 parent de8773f commit d7aa294

File tree

2 files changed

+0
-28
lines changed

2 files changed

+0
-28
lines changed

drivers/accel/habanalabs/common/habanalabs.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1520,8 +1520,6 @@ struct engines_data {
15201520
* @asic_dma_pool_free: free small DMA allocation from pool.
15211521
* @cpu_accessible_dma_pool_alloc: allocate CPU PQ packet from DMA pool.
15221522
* @cpu_accessible_dma_pool_free: free CPU PQ packet from DMA pool.
1523-
* @asic_dma_unmap_single: unmap a single DMA buffer
1524-
* @asic_dma_map_single: map a single buffer to a DMA
15251523
* @hl_dma_unmap_sgtable: DMA unmap scatter-gather table.
15261524
* @cs_parser: parse Command Submission.
15271525
* @asic_dma_map_sgtable: DMA map scatter-gather table.
@@ -1645,12 +1643,6 @@ struct hl_asic_funcs {
16451643
size_t size, dma_addr_t *dma_handle);
16461644
void (*cpu_accessible_dma_pool_free)(struct hl_device *hdev,
16471645
size_t size, void *vaddr);
1648-
void (*asic_dma_unmap_single)(struct hl_device *hdev,
1649-
dma_addr_t dma_addr, int len,
1650-
enum dma_data_direction dir);
1651-
dma_addr_t (*asic_dma_map_single)(struct hl_device *hdev,
1652-
void *addr, int len,
1653-
enum dma_data_direction dir);
16541646
void (*hl_dma_unmap_sgtable)(struct hl_device *hdev,
16551647
struct sg_table *sgt,
16561648
enum dma_data_direction dir);

drivers/accel/habanalabs/gaudi2/gaudi2.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6731,24 +6731,6 @@ static void gaudi2_cpu_accessible_dma_pool_free(struct hl_device *hdev, size_t s
67316731
hl_fw_cpu_accessible_dma_pool_free(hdev, size, vaddr);
67326732
}
67336733

6734-
static dma_addr_t gaudi2_dma_map_single(struct hl_device *hdev, void *addr, int len,
6735-
enum dma_data_direction dir)
6736-
{
6737-
dma_addr_t dma_addr;
6738-
6739-
dma_addr = dma_map_single(&hdev->pdev->dev, addr, len, dir);
6740-
if (unlikely(dma_mapping_error(&hdev->pdev->dev, dma_addr)))
6741-
return 0;
6742-
6743-
return dma_addr;
6744-
}
6745-
6746-
static void gaudi2_dma_unmap_single(struct hl_device *hdev, dma_addr_t addr, int len,
6747-
enum dma_data_direction dir)
6748-
{
6749-
dma_unmap_single(&hdev->pdev->dev, addr, len, dir);
6750-
}
6751-
67526734
static int gaudi2_validate_cb_address(struct hl_device *hdev, struct hl_cs_parser *parser)
67536735
{
67546736
struct asic_fixed_properties *asic_prop = &hdev->asic_prop;
@@ -11515,8 +11497,6 @@ static const struct hl_asic_funcs gaudi2_funcs = {
1151511497
.asic_dma_pool_free = gaudi2_dma_pool_free,
1151611498
.cpu_accessible_dma_pool_alloc = gaudi2_cpu_accessible_dma_pool_alloc,
1151711499
.cpu_accessible_dma_pool_free = gaudi2_cpu_accessible_dma_pool_free,
11518-
.asic_dma_unmap_single = gaudi2_dma_unmap_single,
11519-
.asic_dma_map_single = gaudi2_dma_map_single,
1152011500
.hl_dma_unmap_sgtable = hl_dma_unmap_sgtable,
1152111501
.cs_parser = gaudi2_cs_parser,
1152211502
.asic_dma_map_sgtable = hl_dma_map_sgtable,

0 commit comments

Comments
 (0)