Skip to content

Commit d7b0615

Browse files
committed
srcu: Update cleanup_srcu_struct() comment
Now that we have polled SRCU grace periods, a grace period can be started by start_poll_synchronize_srcu() as well as call_srcu(), synchronize_srcu(), and synchronize_srcu_expedited(). This commit therefore calls out this new start_poll_synchronize_srcu() possibility in the comment on the WARN_ON(). Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 395e73b commit d7b0615

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/rcu/srcutree.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,10 @@ void cleanup_srcu_struct(struct srcu_struct *ssp)
667667
pr_info("%s: Active srcu_struct %p read state: %d gp state: %lu/%lu\n",
668668
__func__, ssp, rcu_seq_state(READ_ONCE(sup->srcu_gp_seq)),
669669
rcu_seq_current(&sup->srcu_gp_seq), sup->srcu_gp_seq_needed);
670-
return; /* Caller forgot to stop doing call_srcu()? */
670+
return; // Caller forgot to stop doing call_srcu()?
671+
// Or caller invoked start_poll_synchronize_srcu()
672+
// and then cleanup_srcu_struct() before that grace
673+
// period ended?
671674
}
672675
kfree(sup->node);
673676
sup->node = NULL;

0 commit comments

Comments
 (0)