Skip to content

Commit d7df6f2

Browse files
author
Marc Zyngier
committed
KVM: arm64: vgic: Use {get,put}_user() instead of copy_{from.to}_user
Tidy-up vgic_get_common_attr() and vgic_set_common_attr() to use {get,put}_user() instead of the more complex (and less type-safe) copy_{from,to}_user(). Reviewed-by: Reiji Watanabe <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent 7e9f723 commit d7df6f2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arch/arm64/kvm/vgic/vgic-kvm-device.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ static int vgic_set_common_attr(struct kvm_device *dev,
170170
u64 addr;
171171
unsigned long type = (unsigned long)attr->attr;
172172

173-
if (copy_from_user(&addr, uaddr, sizeof(addr)))
173+
if (get_user(addr, uaddr))
174174
return -EFAULT;
175175

176176
r = kvm_vgic_addr(dev->kvm, type, &addr, true);
@@ -233,14 +233,14 @@ static int vgic_get_common_attr(struct kvm_device *dev,
233233
u64 addr;
234234
unsigned long type = (unsigned long)attr->attr;
235235

236-
if (copy_from_user(&addr, uaddr, sizeof(addr)))
236+
if (get_user(addr, uaddr))
237237
return -EFAULT;
238238

239239
r = kvm_vgic_addr(dev->kvm, type, &addr, false);
240240
if (r)
241241
return (r == -ENODEV) ? -ENXIO : r;
242242

243-
if (copy_to_user(uaddr, &addr, sizeof(addr)))
243+
if (put_user(addr, uaddr))
244244
return -EFAULT;
245245
break;
246246
}

0 commit comments

Comments
 (0)