Skip to content

Commit d841406

Browse files
vittyvksean-jc
authored andcommitted
KVM: selftests: Re-enable hyperv_evmcs/hyperv_svm_test on bare metal
KVM_CAP_HYPERV_DIRECT_TLBFLUSH is only reported when KVM runs on top of Hyper-V and hyperv_evmcs/hyperv_svm_test don't need that, these tests check that the feature is properly emulated for Hyper-V on KVM guests. There's no corresponding CAP for that, the feature is reported in KVM_GET_SUPPORTED_HV_CPUID. Hyper-V specific CPUIDs are not reported by KVM_GET_SUPPORTED_CPUID, implement dedicated kvm_hv_cpu_has() helper to do the job. Fixes: 6dac119 ("KVM: selftests: Make Hyper-V tests explicitly require KVM Hyper-V support") Signed-off-by: Vitaly Kuznetsov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sean Christopherson <[email protected]>
1 parent 24a7e94 commit d841406

File tree

4 files changed

+24
-2
lines changed

4 files changed

+24
-2
lines changed

tools/testing/selftests/kvm/include/x86_64/hyperv.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,18 @@
186186
#define HV_X64_ENLIGHTENED_VMCS_RECOMMENDED \
187187
KVM_X86_CPU_FEATURE(HYPERV_CPUID_ENLIGHTMENT_INFO, 0, EAX, 14)
188188

189+
/* HYPERV_CPUID_NESTED_FEATURES.EAX */
190+
#define HV_X64_NESTED_DIRECT_FLUSH \
191+
KVM_X86_CPU_FEATURE(HYPERV_CPUID_NESTED_FEATURES, 0, EAX, 17)
192+
#define HV_X64_NESTED_GUEST_MAPPING_FLUSH \
193+
KVM_X86_CPU_FEATURE(HYPERV_CPUID_NESTED_FEATURES, 0, EAX, 18)
194+
#define HV_X64_NESTED_MSR_BITMAP \
195+
KVM_X86_CPU_FEATURE(HYPERV_CPUID_NESTED_FEATURES, 0, EAX, 19)
196+
197+
/* HYPERV_CPUID_NESTED_FEATURES.EBX */
198+
#define HV_X64_NESTED_EVMCS1_PERF_GLOBAL_CTRL \
199+
KVM_X86_CPU_FEATURE(HYPERV_CPUID_NESTED_FEATURES, 0, EBX, 0)
200+
189201
/* HYPERV_CPUID_SYNDBG_PLATFORM_CAPABILITIES.EAX */
190202
#define HV_X64_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING \
191203
KVM_X86_CPU_FEATURE(HYPERV_CPUID_SYNDBG_PLATFORM_CAPABILITIES, 0, EAX, 1)
@@ -347,4 +359,6 @@ const struct kvm_cpuid2 *kvm_get_supported_hv_cpuid(void);
347359
const struct kvm_cpuid2 *vcpu_get_supported_hv_cpuid(struct kvm_vcpu *vcpu);
348360
void vcpu_set_hv_cpuid(struct kvm_vcpu *vcpu);
349361

362+
bool kvm_hv_cpu_has(struct kvm_x86_cpu_feature feature);
363+
350364
#endif /* !SELFTEST_KVM_HYPERV_H */

tools/testing/selftests/kvm/lib/x86_64/hyperv.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@ const struct kvm_cpuid2 *vcpu_get_supported_hv_cpuid(struct kvm_vcpu *vcpu)
6767
return cpuid;
6868
}
6969

70+
bool kvm_hv_cpu_has(struct kvm_x86_cpu_feature feature)
71+
{
72+
if (!kvm_has_cap(KVM_CAP_SYS_HYPERV_CPUID))
73+
return false;
74+
75+
return kvm_cpuid_has(kvm_get_supported_hv_cpuid(), feature);
76+
}
77+
7078
struct hyperv_test_pages *vcpu_alloc_hyperv_test_pages(struct kvm_vm *vm,
7179
vm_vaddr_t *p_hv_pages_gva)
7280
{

tools/testing/selftests/kvm/x86_64/hyperv_evmcs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ int main(int argc, char *argv[])
242242
TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_VMX));
243243
TEST_REQUIRE(kvm_has_cap(KVM_CAP_NESTED_STATE));
244244
TEST_REQUIRE(kvm_has_cap(KVM_CAP_HYPERV_ENLIGHTENED_VMCS));
245-
TEST_REQUIRE(kvm_has_cap(KVM_CAP_HYPERV_DIRECT_TLBFLUSH));
245+
TEST_REQUIRE(kvm_hv_cpu_has(HV_X64_NESTED_DIRECT_FLUSH));
246246

247247
vm = vm_create_with_one_vcpu(&vcpu, guest_code);
248248

tools/testing/selftests/kvm/x86_64/hyperv_svm_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ int main(int argc, char *argv[])
157157
int stage;
158158

159159
TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SVM));
160-
TEST_REQUIRE(kvm_has_cap(KVM_CAP_HYPERV_DIRECT_TLBFLUSH));
160+
TEST_REQUIRE(kvm_hv_cpu_has(HV_X64_NESTED_DIRECT_FLUSH));
161161

162162
/* Create VM */
163163
vm = vm_create_with_one_vcpu(&vcpu, guest_code);

0 commit comments

Comments
 (0)