Skip to content

Commit d8558ac

Browse files
stepardobjorn-helgaas
authored andcommitted
PCI: Fix Intel ACS quirk UPDCR register address
According to documentation [0] the correct offset for the Upstream Peer Decode Configuration Register (UPDCR) is 0x1014. It was previously defined as 0x1114. d99321b ("PCI: Enable quirks for PCIe ACS on Intel PCH root ports") intended to enforce isolation between PCI devices allowing them to be put into separate IOMMU groups. Due to the wrong register offset the intended isolation was not fully enforced. This is fixed with this patch. Please note that I did not test this patch because I have no hardware that implements this register. [0] https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/4th-gen-core-family-mobile-i-o-datasheet.pdf (page 325) Fixes: d99321b ("PCI: Enable quirks for PCIe ACS on Intel PCH root ports") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Steffen Liebergeld <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Andrew Murray <[email protected]> Acked-by: Ashok Raj <[email protected]> Cc: [email protected] # v3.15+
1 parent fef2dd8 commit d8558ac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/quirks.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4706,7 +4706,7 @@ int pci_dev_specific_acs_enabled(struct pci_dev *dev, u16 acs_flags)
47064706
#define INTEL_BSPR_REG_BPPD (1 << 9)
47074707

47084708
/* Upstream Peer Decode Configuration Register */
4709-
#define INTEL_UPDCR_REG 0x1114
4709+
#define INTEL_UPDCR_REG 0x1014
47104710
/* 5:0 Peer Decode Enable bits */
47114711
#define INTEL_UPDCR_REG_MASK 0x3f
47124712

0 commit comments

Comments
 (0)