Skip to content

Commit d8cac85

Browse files
edumazetkuba-moo
authored andcommitted
phonet: fix rtm_phonet_notify() skb allocation
fill_route() stores three components in the skb: - struct rtmsg - RTA_DST (u8) - RTA_OIF (u32) Therefore, rtm_phonet_notify() should use NLMSG_ALIGN(sizeof(struct rtmsg)) + nla_total_size(1) + nla_total_size(4) Fixes: f062f41 ("Phonet: routing table Netlink interface") Signed-off-by: Eric Dumazet <[email protected]> Acked-by: Rémi Denis-Courmont <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent a26ff37 commit d8cac85

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/phonet/pn_netlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ void rtm_phonet_notify(int event, struct net_device *dev, u8 dst)
193193
struct sk_buff *skb;
194194
int err = -ENOBUFS;
195195

196-
skb = nlmsg_new(NLMSG_ALIGN(sizeof(struct ifaddrmsg)) +
196+
skb = nlmsg_new(NLMSG_ALIGN(sizeof(struct rtmsg)) +
197197
nla_total_size(1) + nla_total_size(4), GFP_KERNEL);
198198
if (skb == NULL)
199199
goto errout;

0 commit comments

Comments
 (0)