Skip to content

Commit d9012a5

Browse files
Chengming Zhouaxboe
authored andcommitted
iocost: Fix check condition of iocg abs_vdebt
We shouldn't skip iocg when its abs_vdebt is not zero. Fixes: 0b80f98 ("iocost: protect iocg->abs_vdebt with iocg->waitq.lock") Signed-off-by: Chengming Zhou <[email protected]> Acked-by: Tejun Heo <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 0516c2f commit d9012a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

block/blk-iocost.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,7 @@ static void ioc_timer_fn(struct timer_list *timer)
13701370
* should have woken up in the last period and expire idle iocgs.
13711371
*/
13721372
list_for_each_entry_safe(iocg, tiocg, &ioc->active_iocgs, active_list) {
1373-
if (!waitqueue_active(&iocg->waitq) && iocg->abs_vdebt &&
1373+
if (!waitqueue_active(&iocg->waitq) && !iocg->abs_vdebt &&
13741374
!iocg_is_idle(iocg))
13751375
continue;
13761376

0 commit comments

Comments
 (0)