Skip to content

Commit d91e775

Browse files
kishonLorenzo Pieralisi
authored andcommitted
dt-bindings: PCI: ti,am65: Fix "ti,syscon-pcie-id"/"ti,syscon-pcie-mode" to take argument
Fix binding documentation of "ti,syscon-pcie-id" and "ti,syscon-pcie-mode" to take phandle with argument. The argument is the register offset within "syscon" used to configure PCIe controller. Similar change for j721e is discussed in [1] [1] -> http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kishon Vijay Abraham I <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Rob Herring <[email protected]>
1 parent fa55b7d commit d91e775

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

Documentation/devicetree/bindings/pci/ti,am65-pci-ep.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,12 @@ properties:
3232
maxItems: 1
3333

3434
ti,syscon-pcie-mode:
35+
$ref: /schemas/types.yaml#/definitions/phandle-array
36+
items:
37+
- items:
38+
- description: Phandle to the SYSCON entry
39+
- description: pcie_ctrl register offset within SYSCON
3540
description: Phandle to the SYSCON entry required for configuring PCIe in RC or EP mode.
36-
$ref: /schemas/types.yaml#/definitions/phandle
3741

3842
interrupts:
3943
minItems: 1
@@ -65,7 +69,7 @@ examples:
6569
<0x5506000 0x1000>;
6670
reg-names = "app", "dbics", "addr_space", "atu";
6771
power-domains = <&k3_pds 120 TI_SCI_PD_EXCLUSIVE>;
68-
ti,syscon-pcie-mode = <&pcie0_mode>;
72+
ti,syscon-pcie-mode = <&scm_conf 0x4060>;
6973
num-ib-windows = <16>;
7074
num-ob-windows = <16>;
7175
max-link-speed = <2>;

Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,20 @@ properties:
3333
maxItems: 1
3434

3535
ti,syscon-pcie-id:
36+
$ref: /schemas/types.yaml#/definitions/phandle-array
37+
items:
38+
- items:
39+
- description: Phandle to the SYSCON entry
40+
- description: pcie_device_id register offset within SYSCON
3641
description: Phandle to the SYSCON entry required for getting PCIe device/vendor ID
37-
$ref: /schemas/types.yaml#/definitions/phandle
3842

3943
ti,syscon-pcie-mode:
44+
$ref: /schemas/types.yaml#/definitions/phandle-array
45+
items:
46+
- items:
47+
- description: Phandle to the SYSCON entry
48+
- description: pcie_ctrl register offset within SYSCON
4049
description: Phandle to the SYSCON entry required for configuring PCIe in RC or EP mode.
41-
$ref: /schemas/types.yaml#/definitions/phandle
4250

4351
msi-map: true
4452

@@ -84,8 +92,8 @@ examples:
8492
#size-cells = <2>;
8593
ranges = <0x81000000 0 0 0x10020000 0 0x00010000>,
8694
<0x82000000 0 0x10030000 0x10030000 0 0x07FD0000>;
87-
ti,syscon-pcie-id = <&pcie_devid>;
88-
ti,syscon-pcie-mode = <&pcie0_mode>;
95+
ti,syscon-pcie-id = <&scm_conf 0x0210>;
96+
ti,syscon-pcie-mode = <&scm_conf 0x4060>;
8997
bus-range = <0x0 0xff>;
9098
num-viewport = <16>;
9199
max-link-speed = <2>;

0 commit comments

Comments
 (0)