Skip to content

Commit d9361cb

Browse files
committed
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
Pull crypto fix from Herbert Xu: "This fixes a regression in af_alg" * 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6: crypto: algif_aead - fix uninitialized ctx->init
2 parents 0fd9cc6 + 21dfbcd commit d9361cb

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

crypto/algif_aead.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -554,12 +554,6 @@ static int aead_accept_parent_nokey(void *private, struct sock *sk)
554554

555555
INIT_LIST_HEAD(&ctx->tsgl_list);
556556
ctx->len = len;
557-
ctx->used = 0;
558-
atomic_set(&ctx->rcvused, 0);
559-
ctx->more = 0;
560-
ctx->merge = 0;
561-
ctx->enc = 0;
562-
ctx->aead_assoclen = 0;
563557
crypto_init_wait(&ctx->wait);
564558

565559
ask->private = ctx;

crypto/algif_skcipher.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -329,23 +329,18 @@ static int skcipher_accept_parent_nokey(void *private, struct sock *sk)
329329
ctx = sock_kmalloc(sk, len, GFP_KERNEL);
330330
if (!ctx)
331331
return -ENOMEM;
332+
memset(ctx, 0, len);
332333

333334
ctx->iv = sock_kmalloc(sk, crypto_skcipher_ivsize(tfm),
334335
GFP_KERNEL);
335336
if (!ctx->iv) {
336337
sock_kfree_s(sk, ctx, len);
337338
return -ENOMEM;
338339
}
339-
340340
memset(ctx->iv, 0, crypto_skcipher_ivsize(tfm));
341341

342342
INIT_LIST_HEAD(&ctx->tsgl_list);
343343
ctx->len = len;
344-
ctx->used = 0;
345-
atomic_set(&ctx->rcvused, 0);
346-
ctx->more = 0;
347-
ctx->merge = 0;
348-
ctx->enc = 0;
349344
crypto_init_wait(&ctx->wait);
350345

351346
ask->private = ctx;

0 commit comments

Comments
 (0)