Skip to content

Commit d9917c7

Browse files
author
Paolo Abeni
committed
Merge branch 'net-phy-remove-calls-to-devm_hwmon_sanitize_name'
Heiner Kallweit says: ==================== net: phy: remove calls to devm_hwmon_sanitize_name Since c909e68 ("hwmon: (core) Use device name as a fallback in devm_hwmon_device_register_with_info") we can simply provide NULL as name argument. ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
2 parents 3fed9fd + 345be5c commit d9917c7

File tree

4 files changed

+8
-34
lines changed

4 files changed

+8
-34
lines changed

drivers/net/phy/marvell-88q2xxx.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -765,16 +765,10 @@ static int mv88q2xxx_hwmon_probe(struct phy_device *phydev)
765765
struct mv88q2xxx_priv *priv = phydev->priv;
766766
struct device *dev = &phydev->mdio.dev;
767767
struct device *hwmon;
768-
char *hwmon_name;
769768

770769
priv->enable_temp = true;
771-
hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
772-
if (IS_ERR(hwmon_name))
773-
return PTR_ERR(hwmon_name);
774770

775-
hwmon = devm_hwmon_device_register_with_info(dev,
776-
hwmon_name,
777-
phydev,
771+
hwmon = devm_hwmon_device_register_with_info(dev, NULL, phydev,
778772
&mv88q2xxx_hwmon_chip_info,
779773
NULL);
780774

drivers/net/phy/mxl-gpy.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -225,14 +225,8 @@ static int gpy_hwmon_register(struct phy_device *phydev)
225225
{
226226
struct device *dev = &phydev->mdio.dev;
227227
struct device *hwmon_dev;
228-
char *hwmon_name;
229228

230-
hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
231-
if (IS_ERR(hwmon_name))
232-
return PTR_ERR(hwmon_name);
233-
234-
hwmon_dev = devm_hwmon_device_register_with_info(dev, hwmon_name,
235-
phydev,
229+
hwmon_dev = devm_hwmon_device_register_with_info(dev, NULL, phydev,
236230
&gpy_hwmon_chip_info,
237231
NULL);
238232

drivers/net/phy/nxp-tja11xx.c

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@
8787
#define TJA110X_RMII_MODE_REFCLK_IN BIT(0)
8888

8989
struct tja11xx_priv {
90-
char *hwmon_name;
91-
struct device *hwmon_dev;
9290
struct phy_device *phydev;
9391
struct work_struct phy_register_work;
9492
u32 flags;
@@ -508,19 +506,12 @@ static const struct hwmon_chip_info tja11xx_hwmon_chip_info = {
508506
static int tja11xx_hwmon_register(struct phy_device *phydev,
509507
struct tja11xx_priv *priv)
510508
{
511-
struct device *dev = &phydev->mdio.dev;
512-
513-
priv->hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
514-
if (IS_ERR(priv->hwmon_name))
515-
return PTR_ERR(priv->hwmon_name);
516-
517-
priv->hwmon_dev =
518-
devm_hwmon_device_register_with_info(dev, priv->hwmon_name,
519-
phydev,
520-
&tja11xx_hwmon_chip_info,
521-
NULL);
509+
struct device *hdev, *dev = &phydev->mdio.dev;
522510

523-
return PTR_ERR_OR_ZERO(priv->hwmon_dev);
511+
hdev = devm_hwmon_device_register_with_info(dev, NULL, phydev,
512+
&tja11xx_hwmon_chip_info,
513+
NULL);
514+
return PTR_ERR_OR_ZERO(hdev);
524515
}
525516

526517
static int tja11xx_parse_dt(struct phy_device *phydev)

drivers/net/phy/realtek/realtek_hwmon.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,11 @@ static const struct hwmon_chip_info rtl822x_hwmon_chip_info = {
6363
int rtl822x_hwmon_init(struct phy_device *phydev)
6464
{
6565
struct device *hwdev, *dev = &phydev->mdio.dev;
66-
const char *name;
6766

6867
/* Ensure over-temp alarm is reset. */
6968
phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, RTL822X_VND2_TSALRM, 3);
7069

71-
name = devm_hwmon_sanitize_name(dev, dev_name(dev));
72-
if (IS_ERR(name))
73-
return PTR_ERR(name);
74-
75-
hwdev = devm_hwmon_device_register_with_info(dev, name, phydev,
70+
hwdev = devm_hwmon_device_register_with_info(dev, NULL, phydev,
7671
&rtl822x_hwmon_chip_info,
7772
NULL);
7873
return PTR_ERR_OR_ZERO(hwdev);

0 commit comments

Comments
 (0)