Skip to content

Commit d9a2b5e

Browse files
jhovoldvinodkoul
authored andcommitted
soundwire: bus: suppress probe deferral errors
Soundwire driver probe errors are currently being logged both by the bus code and driver core: wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -12 wsa884x-codec sdw:4:0:0217:0204:00:0: probe with driver wsa884x-codec failed with error -12 Drop the redundant bus error message, which is also incorrectly being logged on probe deferral: wsa884x-codec sdw:4:0:0217:0204:00:0: Probe of wsa884x-codec failed: -517 Note that no soundwire driver uses the driver struct name field, which will be removed by a follow-on change. Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 8400291 commit d9a2b5e

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/soundwire/bus_type.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ static int sdw_drv_probe(struct device *dev)
8383
struct sdw_slave *slave = dev_to_sdw_dev(dev);
8484
struct sdw_driver *drv = drv_to_sdw_driver(dev->driver);
8585
const struct sdw_device_id *id;
86-
const char *name;
8786
int ret;
8887

8988
/*
@@ -108,11 +107,6 @@ static int sdw_drv_probe(struct device *dev)
108107

109108
ret = drv->probe(slave, id);
110109
if (ret) {
111-
name = drv->name;
112-
if (!name)
113-
name = drv->driver.name;
114-
115-
dev_err(dev, "Probe of %s failed: %d\n", name, ret);
116110
dev_pm_domain_detach(dev, false);
117111
return ret;
118112
}

0 commit comments

Comments
 (0)