Skip to content

Commit d9f0a97

Browse files
Su Huiarndb
authored andcommitted
soc: aspeed: lpc: Fix impossible judgment condition
smatch error: drivers/soc/aspeed/aspeed-lpc-snoop.c:169 aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero platform_get_irq() return non-zero IRQ number or negative error code, change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. Fixes: 9f4f9ae ("drivers/misc: add Aspeed LPC snoop driver") Signed-off-by: Su Hui <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Andrew Jeffery <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]>
1 parent e4f59f8 commit d9f0a97

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/soc/aspeed/aspeed-lpc-snoop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
166166
int rc;
167167

168168
lpc_snoop->irq = platform_get_irq(pdev, 0);
169-
if (!lpc_snoop->irq)
169+
if (lpc_snoop->irq < 0)
170170
return -ENODEV;
171171

172172
rc = devm_request_irq(dev, lpc_snoop->irq,

0 commit comments

Comments
 (0)