Skip to content

Commit d9f12a3

Browse files
Uwe Kleine-Königdtor
authored andcommitted
Input: tps65219-pwrbutton - use regmap_set_bits()
regmap_set_bits() is equivalent to regmap_update_bits() if mask == val. The probe function uses regmap_clear_bits() to enable irqs, so symmetrically make use of regmap_set_bits() to disable them. There is no semantic difference. Signed-off-by: Uwe Kleine-König <[email protected]> Reviewed-by: Markus Schneider-Pargmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
1 parent ab892b7 commit d9f12a3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/input/misc/tps65219-pwrbutton.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,8 @@ static void tps65219_pb_remove(struct platform_device *pdev)
123123
int ret;
124124

125125
/* Disable interrupt for the pushbutton */
126-
ret = regmap_update_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,
127-
TPS65219_REG_MASK_INT_FOR_PB_MASK,
128-
TPS65219_REG_MASK_INT_FOR_PB_MASK);
126+
ret = regmap_set_bits(tps->regmap, TPS65219_REG_MASK_CONFIG,
127+
TPS65219_REG_MASK_INT_FOR_PB_MASK);
129128
if (ret)
130129
dev_warn(&pdev->dev, "Failed to disable irq (%pe)\n", ERR_PTR(ret));
131130
}

0 commit comments

Comments
 (0)