usb: typec: ucsi: make yoga_c630_ucsi_ops be static

Pei Xiao · gregkh · commit da31486bf234 · 2024-12-27T13:06:53.000+01:00
sparse warnings: drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse: symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static? Add static to fix sparse warnings. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412102033.J4vZNaaR-lkp@intel.com/ Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> Link: https://lore.kernel.org/r/cefe3bc20b2ddaee2a0924ba32243f035e92a025.1735289530.git.xiaopei01@kylinos.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/typec/ucsi/ucsi_yoga_c630.c b/drivers/usb/typec/ucsi/ucsi_yoga_c630.c
@@ -71,7 +71,7 @@ static int yoga_c630_ucsi_async_control(struct ucsi *ucsi, u64 command)
 	return yoga_c630_ec_ucsi_write(uec->ec, (u8*)&command);
 }
 
-const struct ucsi_operations yoga_c630_ucsi_ops = {
+static const struct ucsi_operations yoga_c630_ucsi_ops = {
 	.read_version = yoga_c630_ucsi_read_version,
 	.read_cci = yoga_c630_ucsi_read_cci,
 	.read_message_in = yoga_c630_ucsi_read_message_in,

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ static int yoga_c630_ucsi_async_control(struct ucsi *ucsi, u64 command)`
`71`	`71`	`return yoga_c630_ec_ucsi_write(uec->ec, (u8*)&command);`
`72`	`72`	`}`
`73`	`73`
`74`		`-const struct ucsi_operations yoga_c630_ucsi_ops = {`
	`74`	`+static const struct ucsi_operations yoga_c630_ucsi_ops = {`
`75`	`75`	`.read_version = yoga_c630_ucsi_read_version,`
`76`	`76`	`.read_cci = yoga_c630_ucsi_read_cci,`
`77`	`77`	`.read_message_in = yoga_c630_ucsi_read_message_in,`