ext4: remove the call to fiemap_check_flags in ext4_fiemap

Christoph Hellwig · tytso · commit da565e792be5 · 2020-06-03T23:16:54.000-04:00
iomap_fiemap already calls fiemap_check_flags first thing, so this additional check is redundant. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20200523073016.2944131-3-hch@lst.de Signed-off-by: Theodore Ts'o <tytso@mit.edu>
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
@@ -4896,9 +4896,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
 		fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE;
 	}
 
-	if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC | FIEMAP_FLAG_XATTR))
-		return -EBADR;
-
 	/*
 	 * For bitmap files the maximum size limit could be smaller than
 	 * s_maxbytes, so check len here manually instead of just relying on the

Original file line number	Diff line number	Diff line change
`@@ -4896,9 +4896,6 @@ int ext4_fiemap(struct inode inode, struct fiemap_extent_info fieinfo,`
`4896`	`4896`	`fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE;`
`4897`	`4897`	`}`
`4898`	`4898`
`4899`		`- if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC \| FIEMAP_FLAG_XATTR))`
`4900`		`- return -EBADR;`
`4901`		`-`
`4902`	`4899`	`/*`
`4903`	`4900`	`* For bitmap files the maximum size limit could be smaller than`
`4904`	`4901`	`* s_maxbytes, so check len here manually instead of just relying on the`