Skip to content

Commit da791ba

Browse files
wvk86kuba-moo
authored andcommitted
net: stmmac: remove redunctant disable xPCS EEE call
Disable is done in stmmac_init_eee() on the event of MAC link down. Since setting enable/disable EEE via ethtool will eventually trigger a MAC down, removing this redunctant call in stmmac_ethtool.c to avoid calling xpcs_config_eee() twice. Fixes: d4aeaed ("net: stmmac: trigger PCS EEE to turn off on link down") Signed-off-by: Wong Vee Khee <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 49a2f5c commit da791ba

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -803,14 +803,6 @@ static int stmmac_ethtool_op_set_eee(struct net_device *dev,
803803
netdev_warn(priv->dev,
804804
"Setting EEE tx-lpi is not supported\n");
805805

806-
if (priv->hw->xpcs) {
807-
ret = xpcs_config_eee(priv->hw->xpcs,
808-
priv->plat->mult_fact_100ns,
809-
edata->eee_enabled);
810-
if (ret)
811-
return ret;
812-
}
813-
814806
if (!edata->eee_enabled)
815807
stmmac_disable_eee_mode(priv);
816808

0 commit comments

Comments
 (0)