platform/chrome: cros_ec: Do not attempt to register a non-positive IRQ number

gwendalcr · Enric Balletbo i Serra · commit da946589b1b9 · 2019-11-21T11:23:15.000+01:00
Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.

Signed-off-by: Enrico Granata &lt;egranata@chromium.org&gt;
Signed-off-by: Gwendal Grignou &lt;gwendal@chromium.org&gt;
Acked-by: Jonathan Cameron &lt;Jonathan.Cameron@huawei.com&gt;
Acked-by: Lee Jones &lt;lee.jones@linaro.org&gt;
Signed-off-by: Enric Balletbo i Serra &lt;enric.balletbo@collabora.com&gt;
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
@@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 		return err;
 	}
 
-	if (ec_dev->irq) {
+	if (ec_dev->irq > 0) {
 		err = devm_request_threaded_irq(dev, ec_dev->irq,
 						ec_irq_handler,
 						ec_irq_thread,

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)`
`149`	`149`	`return err;`
`150`	`150`	`}`
`151`	`151`
`152`		`- if (ec_dev->irq) {`
	`152`	`+ if (ec_dev->irq > 0) {`
`153`	`153`	`err = devm_request_threaded_irq(dev, ec_dev->irq,`
`154`	`154`	`ec_irq_handler,`
`155`	`155`	`ec_irq_thread,`