Skip to content

Commit daaba19

Browse files
Jinjie Ruankuba-moo
authored andcommitted
nfp: Use IRQF_NO_AUTOEN flag in request_irq()
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Reviewed-by: Louis Peens <[email protected]> Signed-off-by: Jinjie Ruan <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 799a922 commit daaba19

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -821,14 +821,13 @@ nfp_net_prepare_vector(struct nfp_net *nn, struct nfp_net_r_vector *r_vec,
821821

822822
snprintf(r_vec->name, sizeof(r_vec->name),
823823
"%s-rxtx-%d", nfp_net_name(nn), idx);
824-
err = request_irq(r_vec->irq_vector, r_vec->handler, 0, r_vec->name,
825-
r_vec);
824+
err = request_irq(r_vec->irq_vector, r_vec->handler, IRQF_NO_AUTOEN,
825+
r_vec->name, r_vec);
826826
if (err) {
827827
nfp_net_napi_del(&nn->dp, r_vec);
828828
nn_err(nn, "Error requesting IRQ %d\n", r_vec->irq_vector);
829829
return err;
830830
}
831-
disable_irq(r_vec->irq_vector);
832831

833832
irq_set_affinity_hint(r_vec->irq_vector, &r_vec->affinity_mask);
834833

0 commit comments

Comments
 (0)