ntb: intel: Fix memleak in intel_ntb_pci_probe

dinghaoliu · jonmason · commit dbb8df5c2d27 · 2020-08-24T10:44:47.000-04:00
The default error branch of a series of pdev_is_gen calls should free ndev just like what we've done in these calls. Fixes: 26bfe3d ("ntb: intel: Add Icelake (gen4) support for Intel NTB") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Acked-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
@@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,
 			goto err_init_dev;
 	} else {
 		rc = -EINVAL;
-		goto err_ndev;
+		goto err_init_pci;
 	}
 
 	ndev_reset_unsafe_flags(ndev);

Original file line number	Diff line number	Diff line change
`@@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,`
`1893`	`1893`	`goto err_init_dev;`
`1894`	`1894`	`} else {`
`1895`	`1895`	`rc = -EINVAL;`
`1896`		`- goto err_ndev;`
	`1896`	`+ goto err_init_pci;`
`1897`	`1897`	`}`
`1898`	`1898`
`1899`	`1899`	`ndev_reset_unsafe_flags(ndev);`