Skip to content

Commit dc09628

Browse files
committed
Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-queue
Tony Nguyen says: ==================== Intel Wired LAN Driver Updates 2020-07-30 This series contains updates to the e1000e and igb drivers. Aaron Ma allows PHY initialization to continue if ULP disable failed for e1000e. Francesco Ruggeri fixes race conditions in igb reset that could cause panics. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 8c5c51f + 024a816 commit dc09628

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

drivers/net/ethernet/intel/e1000e/ich8lan.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,8 @@ static s32 e1000_init_phy_workarounds_pchlan(struct e1000_hw *hw)
301301
*/
302302
hw->dev_spec.ich8lan.ulp_state = e1000_ulp_state_unknown;
303303
ret_val = e1000_disable_ulp_lpt_lp(hw, true);
304-
if (ret_val) {
304+
if (ret_val)
305305
e_warn("Failed to disable ULP\n");
306-
goto out;
307-
}
308306

309307
ret_val = hw->phy.ops.acquire(hw);
310308
if (ret_val) {

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6224,9 +6224,18 @@ static void igb_reset_task(struct work_struct *work)
62246224
struct igb_adapter *adapter;
62256225
adapter = container_of(work, struct igb_adapter, reset_task);
62266226

6227+
rtnl_lock();
6228+
/* If we're already down or resetting, just bail */
6229+
if (test_bit(__IGB_DOWN, &adapter->state) ||
6230+
test_bit(__IGB_RESETTING, &adapter->state)) {
6231+
rtnl_unlock();
6232+
return;
6233+
}
6234+
62276235
igb_dump(adapter);
62286236
netdev_err(adapter->netdev, "Reset adapter\n");
62296237
igb_reinit_locked(adapter);
6238+
rtnl_unlock();
62306239
}
62316240

62326241
/**

0 commit comments

Comments
 (0)