Skip to content

Commit dc2c733

Browse files
andy-shevDaniel Thompson
authored andcommitted
kdb: Use for_each_console() helper
Replace open coded single-linked list iteration loop with for_each_console() helper in use. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Daniel Thompson <[email protected]>
1 parent a4f8a7f commit dc2c733

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

kernel/debug/kdb/kdb_io.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
553553
int this_cpu, old_cpu;
554554
char *cp, *cp2, *cphold = NULL, replaced_byte = ' ';
555555
char *moreprompt = "more> ";
556-
struct console *c = console_drivers;
556+
struct console *c;
557557
unsigned long uninitialized_var(flags);
558558

559559
/* Serialize kdb_printf if multiple cpus try to write at once.
@@ -698,10 +698,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
698698
cp2++;
699699
}
700700
}
701-
while (c) {
701+
for_each_console(c) {
702702
c->write(c, cp, retlen - (cp - kdb_buffer));
703703
touch_nmi_watchdog();
704-
c = c->next;
705704
}
706705
}
707706
if (logging) {
@@ -752,7 +751,6 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
752751
moreprompt = "more> ";
753752

754753
kdb_input_flush();
755-
c = console_drivers;
756754

757755
if (dbg_io_ops && !dbg_io_ops->is_console) {
758756
len = strlen(moreprompt);
@@ -762,10 +760,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
762760
cp++;
763761
}
764762
}
765-
while (c) {
763+
for_each_console(c) {
766764
c->write(c, moreprompt, strlen(moreprompt));
767765
touch_nmi_watchdog();
768-
c = c->next;
769766
}
770767

771768
if (logging)

0 commit comments

Comments
 (0)