Skip to content

Commit dc98e25

Browse files
Tzung-Bi Shihlag-linaro
authored andcommitted
mfd: cros_ec: Simplify and clean-up cros_ec_dev_init()
Simplify cros_ec_dev_init() by the following changes: - Get rid of label `failed_devreg`. - Remove a redundant space and comment. - Use `if (ret)` instead of `if (ret < 0)`. Signed-off-by: Tzung-Bi Shih <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lee Jones <[email protected]>
1 parent 607638b commit dc98e25

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/mfd/cros_ec_dev.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -353,22 +353,17 @@ static int __init cros_ec_dev_init(void)
353353
{
354354
int ret;
355355

356-
ret = class_register(&cros_class);
356+
ret = class_register(&cros_class);
357357
if (ret) {
358358
pr_err(CROS_EC_DEV_NAME ": failed to register device class\n");
359359
return ret;
360360
}
361361

362-
/* Register the driver */
363362
ret = platform_driver_register(&cros_ec_dev_driver);
364-
if (ret < 0) {
363+
if (ret) {
365364
pr_warn(CROS_EC_DEV_NAME ": can't register driver: %d\n", ret);
366-
goto failed_devreg;
365+
class_unregister(&cros_class);
367366
}
368-
return 0;
369-
370-
failed_devreg:
371-
class_unregister(&cros_class);
372367
return ret;
373368
}
374369

0 commit comments

Comments
 (0)