ALSA: hda/tas2781: annotate calibration data endianness

soyersoyer · tiwai · commit dcaca1b5f0d4 · 2024-01-09T15:13:09.000+01:00
Sparse reports an endian mismatch. The amplifier expects the calibration data as big-endian. Use the __be32 type to express endianness better. Fixes: c3ca445 ("ALSA: hda/tas2781: add TAS2563 support for 14ARB7") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/ Signed-off-by: Gergo Koteles <soyer@irl.hu> Link: https://lore.kernel.org/r/3852ff28ea7d5d8f2086d8dd78aeff8d1d984991.1704748435.git.soyer@irl.hu Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
@@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = {
 
 static void tas2563_apply_calib(struct tasdevice_priv *tas_priv)
 {
-	unsigned int data;
 	int offset = 0;
+	__be32 data;
 	int ret;
 
 	for (int i = 0; i < tas_priv->ndev; i++) {

Original file line number	Diff line number	Diff line change
`@@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = {`
`424`	`424`
`425`	`425`	`static void tas2563_apply_calib(struct tasdevice_priv *tas_priv)`
`426`	`426`	`{`
`427`		`- unsigned int data;`
`428`	`427`	`int offset = 0;`
	`428`	`+ __be32 data;`
`429`	`429`	`int ret;`
`430`	`430`
`431`	`431`	`for (int i = 0; i < tas_priv->ndev; i++) {`