Skip to content

Commit dd36ad7

Browse files
Andre-ARMwens
authored andcommitted
ARM: dts: cubieboard4: Fix DCDC5 regulator constraints
The DCDC5 voltage rail in the X-Powers AXP809 PMIC has a resolution of 50mV, so the currently enforced limits of 1.475 and 1.525 volts cannot be set, when the existing regulator value is beyond this range. This will lead to the whole regulator driver to give up and fail probing, which in turn will hang the system, as essential devices depend on the PMIC. In this case a bug in U-Boot set the voltage to 1.75V (meant for DCDC4), and the AXP driver's attempt to correct this lead to this error: ================== [ 4.447653] axp20x-rsb sunxi-rsb-3a3: AXP20X driver loaded [ 4.450066] vcc-dram: Bringing 1750000uV into 1575000-1575000uV [ 4.460272] vcc-dram: failed to apply 1575000-1575000uV constraint: -EINVAL [ 4.474788] axp20x-regulator axp20x-regulator.0: Failed to register dcdc5 [ 4.482276] axp20x-regulator axp20x-regulator.0: probe with driver axp20x-regulator failed with error -22 ================== Set the limits to values that can be programmed, so any correction will be successful. Signed-off-by: Andre Przywara <[email protected]> Fixes: 1e1dea7 ("ARM: dts: sun9i: cubieboard4: Add AXP809 PMIC device node and regulators") Link: https://patch.msgid.link/[email protected] Signed-off-by: Chen-Yu Tsai <[email protected]>
1 parent 9852d85 commit dd36ad7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/arm/boot/dts/allwinner/sun9i-a80-cubieboard4.dts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,8 @@
280280

281281
reg_dcdc5: dcdc5 {
282282
regulator-always-on;
283-
regulator-min-microvolt = <1425000>;
284-
regulator-max-microvolt = <1575000>;
283+
regulator-min-microvolt = <1450000>;
284+
regulator-max-microvolt = <1550000>;
285285
regulator-name = "vcc-dram";
286286
};
287287

0 commit comments

Comments
 (0)