scsi: ses: Fix unsigned comparison with less than zero

Jiapeng Chong · martinkpetersen · commit dd689ed5aa90 · 2021-09-28T22:42:06.000-04:00
Fix the following coccicheck warning: ./drivers/scsi/ses.c:137:10-16: WARNING: Unsigned expression compared with zero: result > 0. Link: https://lore.kernel.org/r/1632477113-90378-1-git-send-email-jiapeng.chong@linux.alibaba.com Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
@@ -118,7 +118,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
 static int ses_send_diag(struct scsi_device *sdev, int page_code,
 			 void *buf, int bufflen)
 {
-	u32 result;
+	int result;
 
 	unsigned char cmd[] = {
 		SEND_DIAGNOSTIC,

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,`
`118`	`118`	`static int ses_send_diag(struct scsi_device *sdev, int page_code,`
`119`	`119`	`void *buf, int bufflen)`
`120`	`120`	`{`
`121`		`- u32 result;`
	`121`	`+ int result;`
`122`	`122`
`123`	`123`	`unsigned char cmd[] = {`
`124`	`124`	`SEND_DIAGNOSTIC,`