Skip to content

Commit dd83f48

Browse files
Kamalheibjgunthorpe
authored andcommitted
RDMA/bnxt_re: Remove unsupported bnxt_re_modify_ah callback
There is no need to return always zero for function which is not supported, especially since 0 is the wrong return code. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 6a463bc commit dd83f48

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

drivers/infiniband/hw/bnxt_re/ib_verbs.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -708,11 +708,6 @@ int bnxt_re_create_ah(struct ib_ah *ib_ah, struct rdma_ah_init_attr *init_attr,
708708
return 0;
709709
}
710710

711-
int bnxt_re_modify_ah(struct ib_ah *ib_ah, struct rdma_ah_attr *ah_attr)
712-
{
713-
return 0;
714-
}
715-
716711
int bnxt_re_query_ah(struct ib_ah *ib_ah, struct rdma_ah_attr *ah_attr)
717712
{
718713
struct bnxt_re_ah *ah = container_of(ib_ah, struct bnxt_re_ah, ib_ah);

drivers/infiniband/hw/bnxt_re/ib_verbs.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ int bnxt_re_alloc_pd(struct ib_pd *pd, struct ib_udata *udata);
166166
int bnxt_re_dealloc_pd(struct ib_pd *pd, struct ib_udata *udata);
167167
int bnxt_re_create_ah(struct ib_ah *ah, struct rdma_ah_init_attr *init_attr,
168168
struct ib_udata *udata);
169-
int bnxt_re_modify_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr);
170169
int bnxt_re_query_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr);
171170
int bnxt_re_destroy_ah(struct ib_ah *ah, u32 flags);
172171
int bnxt_re_create_srq(struct ib_srq *srq,

drivers/infiniband/hw/bnxt_re/main.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,7 +696,6 @@ static const struct ib_device_ops bnxt_re_dev_ops = {
696696
.get_port_immutable = bnxt_re_get_port_immutable,
697697
.map_mr_sg = bnxt_re_map_mr_sg,
698698
.mmap = bnxt_re_mmap,
699-
.modify_ah = bnxt_re_modify_ah,
700699
.modify_qp = bnxt_re_modify_qp,
701700
.modify_srq = bnxt_re_modify_srq,
702701
.poll_cq = bnxt_re_poll_cq,

0 commit comments

Comments
 (0)