Skip to content

Commit dd8689b

Browse files
Nikita Zhandarovichalexdeucher
authored andcommitted
drm/radeon: fix uninitialized size issue in radeon_vce_cs_parse()
On the off chance that command stream passed from userspace via ioctl() call to radeon_vce_cs_parse() is weirdly crafted and first command to execute is to encode (case 0x03000001), the function in question will attempt to call radeon_vce_cs_reloc() with size argument that has not been properly initialized. Specifically, 'size' will point to 'tmp' variable before the latter had a chance to be assigned any value. Play it safe and init 'tmp' with 0, thus ensuring that radeon_vce_cs_reloc() will catch an early error in cases like these. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: 2fc5703 ("drm/radeon: check VCE relocation buffer range v3") Signed-off-by: Nikita Zhandarovich <[email protected]> Signed-off-by: Alex Deucher <[email protected]> (cherry picked from commit 2d52de5) Cc: [email protected]
1 parent 6cc3074 commit dd8689b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/radeon/radeon_vce.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ int radeon_vce_cs_parse(struct radeon_cs_parser *p)
557557
{
558558
int session_idx = -1;
559559
bool destroyed = false, created = false, allocated = false;
560-
uint32_t tmp, handle = 0;
560+
uint32_t tmp = 0, handle = 0;
561561
uint32_t *size = &tmp;
562562
int i, r = 0;
563563

0 commit comments

Comments
 (0)