Skip to content

Commit de08b5a

Browse files
arndbmiquelraynal
authored andcommitted
mtd: sm_ftl: fix NULL pointer warning
With gcc -O3, we get a new warning: In file included from arch/arm64/include/asm/processor.h:28, from drivers/mtd/sm_ftl.c:8: In function 'memset', inlined from 'sm_read_sector.constprop' at drivers/mtd/sm_ftl.c:250:3: include/linux/string.h:411:9: error: argument 1 null where non-null expected [-Werror=nonnull] return __builtin_memset(p, c, size); >From all I can tell, this cannot happen (the function is called either with a NULL buffer or with a -1 block number but not both), but adding a check makes it more robust and avoids the warning. Fixes: mmtom ("init/Kconfig: enable -O3 for all arches") Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Miquel Raynal <[email protected]>
1 parent 8bcef0d commit de08b5a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/mtd/sm_ftl.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,8 @@ static int sm_read_sector(struct sm_ftl *ftl,
247247

248248
/* FTL can contain -1 entries that are by default filled with bits */
249249
if (block == -1) {
250-
memset(buffer, 0xFF, SM_SECTOR_SIZE);
250+
if (buffer)
251+
memset(buffer, 0xFF, SM_SECTOR_SIZE);
251252
return 0;
252253
}
253254

0 commit comments

Comments
 (0)