Skip to content

Commit de3c4bf

Browse files
AnsuelLorenzo Pieralisi
authored andcommitted
PCI: qcom: Add support for tx term offset for rev 2.1.0
Add tx term offset support to pcie qcom driver need in some revision of the ipq806x SoC. Ipq8064 needs tx term offset set to 7. Link: https://lore.kernel.org/r/[email protected] Fixes: 82a8238 ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Sham Muthayyan <[email protected]> Signed-off-by: Ansuel Smith <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Acked-by: Stanimir Varbanov <[email protected]> Cc: [email protected] # v4.5+
1 parent 5149901 commit de3c4bf

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

drivers/pci/controller/dwc/pcie-qcom.c

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,13 @@
4545
#define PCIE_CAP_CPL_TIMEOUT_DISABLE 0x10
4646

4747
#define PCIE20_PARF_PHY_CTRL 0x40
48+
#define PHY_CTRL_PHY_TX0_TERM_OFFSET_MASK GENMASK(20, 16)
49+
#define PHY_CTRL_PHY_TX0_TERM_OFFSET(x) ((x) << 16)
50+
4851
#define PCIE20_PARF_PHY_REFCLK 0x4C
52+
#define PHY_REFCLK_SSP_EN BIT(16)
53+
#define PHY_REFCLK_USE_PAD BIT(12)
54+
4955
#define PCIE20_PARF_DBI_BASE_ADDR 0x168
5056
#define PCIE20_PARF_SLV_ADDR_SPACE_SIZE 0x16C
5157
#define PCIE20_PARF_MHI_CLOCK_RESET_CTRL 0x174
@@ -371,9 +377,18 @@ static int qcom_pcie_init_2_1_0(struct qcom_pcie *pcie)
371377
writel(PHY_RX0_EQ(4), pcie->parf + PCIE20_PARF_CONFIG_BITS);
372378
}
373379

380+
if (of_device_is_compatible(node, "qcom,pcie-ipq8064")) {
381+
/* set TX termination offset */
382+
val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL);
383+
val &= ~PHY_CTRL_PHY_TX0_TERM_OFFSET_MASK;
384+
val |= PHY_CTRL_PHY_TX0_TERM_OFFSET(7);
385+
writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL);
386+
}
387+
374388
/* enable external reference clock */
375389
val = readl(pcie->parf + PCIE20_PARF_PHY_REFCLK);
376-
val |= BIT(16);
390+
val &= ~PHY_REFCLK_USE_PAD;
391+
val |= PHY_REFCLK_SSP_EN;
377392
writel(val, pcie->parf + PCIE20_PARF_PHY_REFCLK);
378393

379394
/* wait for clock acquisition */

0 commit comments

Comments
 (0)