Skip to content

Commit de48984

Browse files
kedderyuq
authored andcommitted
drm/lima: Expose job_hang_limit module parameter
Some pp or gp jobs can be successfully repeated even after they time outs. Introduce lima module parameter to specify number of times a job can hang before being dropped. Signed-off-by: Andrey Lebedev <[email protected]> Signed-off-by: Qiang Yu <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 06a28f9 commit de48984

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

drivers/gpu/drm/lima/lima_drv.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
int lima_sched_timeout_ms;
2020
uint lima_heap_init_nr_pages = 8;
2121
uint lima_max_error_tasks;
22+
uint lima_job_hang_limit;
2223

2324
MODULE_PARM_DESC(sched_timeout_ms, "task run timeout in ms");
2425
module_param_named(sched_timeout_ms, lima_sched_timeout_ms, int, 0444);
@@ -29,6 +30,9 @@ module_param_named(heap_init_nr_pages, lima_heap_init_nr_pages, uint, 0444);
2930
MODULE_PARM_DESC(max_error_tasks, "max number of error tasks to save");
3031
module_param_named(max_error_tasks, lima_max_error_tasks, uint, 0644);
3132

33+
MODULE_PARM_DESC(job_hang_limit, "number of times to allow a job to hang before dropping it (default 0)");
34+
module_param_named(job_hang_limit, lima_job_hang_limit, uint, 0444);
35+
3236
static int lima_ioctl_get_param(struct drm_device *dev, void *data, struct drm_file *file)
3337
{
3438
struct drm_lima_get_param *args = data;

drivers/gpu/drm/lima/lima_drv.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
extern int lima_sched_timeout_ms;
1212
extern uint lima_heap_init_nr_pages;
1313
extern uint lima_max_error_tasks;
14+
extern uint lima_job_hang_limit;
1415

1516
struct lima_vm;
1617
struct lima_bo;

drivers/gpu/drm/lima/lima_sched.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,8 +503,9 @@ int lima_sched_pipe_init(struct lima_sched_pipe *pipe, const char *name)
503503

504504
INIT_WORK(&pipe->recover_work, lima_sched_recover_work);
505505

506-
return drm_sched_init(&pipe->base, &lima_sched_ops, 1, 0,
507-
msecs_to_jiffies(timeout), name);
506+
return drm_sched_init(&pipe->base, &lima_sched_ops, 1,
507+
lima_job_hang_limit, msecs_to_jiffies(timeout),
508+
name);
508509
}
509510

510511
void lima_sched_pipe_fini(struct lima_sched_pipe *pipe)

0 commit comments

Comments
 (0)