Skip to content

Commit de92258

Browse files
kuba-mooPaolo Abeni
authored andcommitted
netlink: specs: rt-link: add missing byte-order properties
A number of fields in the ip tunnels are lacking the big-endian designation. I suspect this is not intentional, as decoding the ports with the right endian seems objectively beneficial. Fixes: 6ffdbb9 ("netlink: specs: rt_link: decode ip6tnl, vti and vti6 link attrs") Fixes: 077b602 ("doc/netlink/specs: Add sub-message type to rt_link family") Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: Donald Hunter <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent ec6a328 commit de92258

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

Documentation/netlink/specs/rt-link.yaml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1685,15 +1685,19 @@ attribute-sets:
16851685
-
16861686
name: iflags
16871687
type: u16
1688+
byte-order: big-endian
16881689
-
16891690
name: oflags
16901691
type: u16
1692+
byte-order: big-endian
16911693
-
16921694
name: ikey
16931695
type: u32
1696+
byte-order: big-endian
16941697
-
16951698
name: okey
16961699
type: u32
1700+
byte-order: big-endian
16971701
-
16981702
name: local
16991703
type: binary
@@ -1717,6 +1721,7 @@ attribute-sets:
17171721
-
17181722
name: flowinfo
17191723
type: u32
1724+
byte-order: big-endian
17201725
-
17211726
name: flags
17221727
type: u32
@@ -1729,9 +1734,11 @@ attribute-sets:
17291734
-
17301735
name: encap-sport
17311736
type: u16
1737+
byte-order: big-endian
17321738
-
17331739
name: encap-dport
17341740
type: u16
1741+
byte-order: big-endian
17351742
-
17361743
name: collect-metadata
17371744
type: flag
@@ -1764,9 +1771,11 @@ attribute-sets:
17641771
-
17651772
name: ikey
17661773
type: u32
1774+
byte-order: big-endian
17671775
-
17681776
name: okey
17691777
type: u32
1778+
byte-order: big-endian
17701779
-
17711780
name: local
17721781
type: binary
@@ -1816,6 +1825,7 @@ attribute-sets:
18161825
-
18171826
name: port
18181827
type: u16
1828+
byte-order: big-endian
18191829
-
18201830
name: collect-metadata
18211831
type: flag
@@ -1835,6 +1845,7 @@ attribute-sets:
18351845
-
18361846
name: label
18371847
type: u32
1848+
byte-order: big-endian
18381849
-
18391850
name: ttl-inherit
18401851
type: u8
@@ -1875,9 +1886,11 @@ attribute-sets:
18751886
-
18761887
name: flowinfo
18771888
type: u32
1889+
byte-order: big-endian
18781890
-
18791891
name: flags
18801892
type: u16
1893+
byte-order: big-endian
18811894
-
18821895
name: proto
18831896
type: u8
@@ -1907,9 +1920,11 @@ attribute-sets:
19071920
-
19081921
name: encap-sport
19091922
type: u16
1923+
byte-order: big-endian
19101924
-
19111925
name: encap-dport
19121926
type: u16
1927+
byte-order: big-endian
19131928
-
19141929
name: collect-metadata
19151930
type: flag

0 commit comments

Comments
 (0)