Skip to content

Commit de9be77

Browse files
Dan Carpenterwsakernel
authored andcommitted
i2c: npcm7xx: Fix a couple of error codes in probe
The code here is accidentally returning IS_ERR() which is 1 but it should be returning negative error codes with PTR_ERR(). Fixes: 56a1485 ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent cdb5553 commit de9be77

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/i2c/busses/i2c-npcm7xx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2239,12 +2239,12 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev)
22392239

22402240
gcr_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-gcr");
22412241
if (IS_ERR(gcr_regmap))
2242-
return IS_ERR(gcr_regmap);
2242+
return PTR_ERR(gcr_regmap);
22432243
regmap_write(gcr_regmap, NPCM_I2CSEGCTL, NPCM_I2CSEGCTL_INIT_VAL);
22442244

22452245
clk_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-clk");
22462246
if (IS_ERR(clk_regmap))
2247-
return IS_ERR(clk_regmap);
2247+
return PTR_ERR(clk_regmap);
22482248

22492249
bus->reg = devm_platform_ioremap_resource(pdev, 0);
22502250
if (IS_ERR(bus->reg))

0 commit comments

Comments
 (0)