Skip to content

Commit decf532

Browse files
Lee Jonesbroonie
authored andcommitted
spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data'
Fixes the following W=1 kernel build warning(s): drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'io_base_addr' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_tx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'pkt_rx_buff' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'use_dma' not described in 'pch_spi_data' drivers/spi/spi-topcliff-pch.c:184: warning: Function parameter or member 'save_total_len' not described in 'pch_spi_data' Signed-off-by: Lee Jones <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 4b42b0b commit decf532

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/spi/spi-topcliff-pch.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ struct pch_spi_dma_ctrl {
122122
/**
123123
* struct pch_spi_data - Holds the SPI channel specific details
124124
* @io_remap_addr: The remapped PCI base address
125+
* @io_base_addr: Base address
125126
* @master: Pointer to the SPI master structure
126127
* @work: Reference to work queue handler
127128
* @wait: Wait queue for waking up upon receiving an
@@ -138,8 +139,8 @@ struct pch_spi_dma_ctrl {
138139
* transfer
139140
* @rx_index: Receive data count; for bookkeeping during
140141
* transfer
141-
* @tx_buff: Buffer for data to be transmitted
142-
* @rx_index: Buffer for Received data
142+
* @pkt_tx_buff: Buffer for data to be transmitted
143+
* @pkt_rx_buff: Buffer for received data
143144
* @n_curnt_chip: The chip number that this SPI driver currently
144145
* operates on
145146
* @current_chip: Reference to the current chip that this SPI
@@ -151,7 +152,10 @@ struct pch_spi_dma_ctrl {
151152
* @board_dat: Reference to the SPI device data structure
152153
* @plat_dev: platform_device structure
153154
* @ch: SPI channel number
155+
* @dma: Local DMA information
156+
* @use_dma: True if DMA is to be used
154157
* @irq_reg_sts: Status of IRQ registration
158+
* @save_total_len: Save length while data is being transferred
155159
*/
156160
struct pch_spi_data {
157161
void __iomem *io_remap_addr;

0 commit comments

Comments
 (0)