Skip to content

Commit df1e979

Browse files
masahir0yherbertx
authored andcommitted
hwrng: core - remove (un)register_miscdev()
These functions are redundant after commit 0daa7a0 ("hwrng: Avoid manual device_create_file() calls"). Let's call misc_(de)register() directly. Signed-off-by: Masahiro Yamada <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent fe69b77 commit df1e979

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

drivers/char/hw_random/core.c

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -486,16 +486,6 @@ static struct attribute *rng_dev_attrs[] = {
486486

487487
ATTRIBUTE_GROUPS(rng_dev);
488488

489-
static void __exit unregister_miscdev(void)
490-
{
491-
misc_deregister(&rng_miscdev);
492-
}
493-
494-
static int __init register_miscdev(void)
495-
{
496-
return misc_register(&rng_miscdev);
497-
}
498-
499489
static int hwrng_fillfn(void *unused)
500490
{
501491
size_t entropy, entropy_credit = 0; /* in 1/1024 of a bit */
@@ -709,7 +699,7 @@ static int __init hwrng_modinit(void)
709699
return -ENOMEM;
710700
}
711701

712-
ret = register_miscdev();
702+
ret = misc_register(&rng_miscdev);
713703
if (ret) {
714704
kfree(rng_fillbuf);
715705
kfree(rng_buffer);
@@ -726,7 +716,7 @@ static void __exit hwrng_modexit(void)
726716
kfree(rng_fillbuf);
727717
mutex_unlock(&rng_mutex);
728718

729-
unregister_miscdev();
719+
misc_deregister(&rng_miscdev);
730720
}
731721

732722
fs_initcall(hwrng_modinit); /* depends on misc_register() */

0 commit comments

Comments
 (0)