Skip to content

Commit df5f6f2

Browse files
Dragan Simicmmind
authored andcommitted
arm64: dts: rockchip: Move L3 cache outside CPUs in RK3588(S) SoC dtsi
Move the "l3_cache" node outside the "cpus" node in the base dtsi file for Rockchip RK3588(S) SoCs. The A55 and A76 CPU cores in these SoCs belong to the ARM DynamIQ IP core lineup, which places the L3 cache outside the CPUs and into the DynamIQ Shared Unit (DSU). [1] Thus, moving the L3 cache DT node one level higher in the DT improves the way the physical topology of the RK3588(S) SoCs is represented in the SoC dtsi files. While there, add a comment that explains it briefly, to save curious readers from the need to reference the repository log for a clarification. [1] ARM DynamIQ Shared Unit revision r4p0 TRM, version 0400-02 Fixes: c9211fa ("arm64: dts: rockchip: Add base DT for rk3588 SoC") Helped-by: Robin Murphy <[email protected]> Signed-off-by: Dragan Simic <[email protected]> Link: https://lore.kernel.org/r/84264d0713fb51ae2b9b731e28fc14681beea853.1727345965.git.dsimic@manjaro.org Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 577b576 commit df5f6f2

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -337,15 +337,19 @@
337337
cache-unified;
338338
next-level-cache = <&l3_cache>;
339339
};
340+
};
340341

341-
l3_cache: l3-cache {
342-
compatible = "cache";
343-
cache-size = <3145728>;
344-
cache-line-size = <64>;
345-
cache-sets = <4096>;
346-
cache-level = <3>;
347-
cache-unified;
348-
};
342+
/*
343+
* The L3 cache belongs to the DynamIQ Shared Unit (DSU),
344+
* so it's represented here, outside the "cpus" node
345+
*/
346+
l3_cache: l3-cache {
347+
compatible = "cache";
348+
cache-size = <3145728>;
349+
cache-line-size = <64>;
350+
cache-sets = <4096>;
351+
cache-level = <3>;
352+
cache-unified;
349353
};
350354

351355
display_subsystem: display-subsystem {

0 commit comments

Comments
 (0)