Skip to content

Commit e08ec05

Browse files
Jinjie Ruankuba-moo
authored andcommitted
net: apple: bmac: Use IRQF_NO_AUTOEN flag in request_irq()
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when request IRQ. Signed-off-by: Jinjie Ruan <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5905c02 commit e08ec05

File tree

1 file changed

+1
-2
lines changed
  • drivers/net/ethernet/apple

1 file changed

+1
-2
lines changed

drivers/net/ethernet/apple/bmac.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,7 +1317,7 @@ static int bmac_probe(struct macio_dev *mdev, const struct of_device_id *match)
13171317

13181318
timer_setup(&bp->tx_timeout, bmac_tx_timeout, 0);
13191319

1320-
ret = request_irq(dev->irq, bmac_misc_intr, 0, "BMAC-misc", dev);
1320+
ret = request_irq(dev->irq, bmac_misc_intr, IRQF_NO_AUTOEN, "BMAC-misc", dev);
13211321
if (ret) {
13221322
printk(KERN_ERR "BMAC: can't get irq %d\n", dev->irq);
13231323
goto err_out_iounmap_rx;
@@ -1336,7 +1336,6 @@ static int bmac_probe(struct macio_dev *mdev, const struct of_device_id *match)
13361336
/* Mask chip interrupts and disable chip, will be
13371337
* re-enabled on open()
13381338
*/
1339-
disable_irq(dev->irq);
13401339
pmac_call_feature(PMAC_FTR_BMAC_ENABLE, macio_get_of_node(bp->mdev), 0, 0);
13411340

13421341
if (register_netdev(dev) != 0) {

0 commit comments

Comments
 (0)