Skip to content

Commit e0d4e8a

Browse files
Su HuiJaegeuk Kim
authored andcommitted
f2fs: avoid format-overflow warning
With gcc and W=1 option, there's a warning like this: fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’: fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between 1 and 7 bytes into a region of size between 5 and 8 [-Werror=format-overflow=] 1984 | sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev), MINOR(dev)); | ^~ String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35". slab_name's size should be 35 rather than 32. Cc: [email protected] Signed-off-by: Su Hui <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 8b07c1f commit e0d4e8a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/f2fs/compress.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1983,7 +1983,7 @@ void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi)
19831983
int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi)
19841984
{
19851985
dev_t dev = sbi->sb->s_bdev->bd_dev;
1986-
char slab_name[32];
1986+
char slab_name[35];
19871987

19881988
if (!f2fs_sb_has_compression(sbi))
19891989
return 0;

0 commit comments

Comments
 (0)