Skip to content

Commit e0dd27a

Browse files
Yicong YangSuzuki K Poulose
authored andcommitted
hwtracing: hisi_ptt: Handle the interrupt in hardirq context
Handle the trace interrupt in the hardirq context, make sure the irq core won't threaded it by declaring IRQF_NO_THREAD and userspace won't balance it by declaring IRQF_NOBALANCING. Otherwise we may violate the synchronization requirements of the perf core, referenced to the change of arm-ccn PMU commit 0811ef7 ("bus: arm-ccn: fix PMU interrupt flags"). In the interrupt handler we mainly doing 2 things: - Copy the data from the local DMA buffer to the AUX buffer - Commit the data in the AUX buffer Signed-off-by: Yicong Yang <[email protected]> Acked-by: Jonathan Cameron <[email protected]> [ Fixed commit description to suppress checkpatch warning ] Signed-off-by: Suzuki K Poulose <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 55e0a2f commit e0dd27a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/hwtracing/ptt/hisi_ptt.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,9 @@ static int hisi_ptt_register_irq(struct hisi_ptt *hisi_ptt)
342342
return ret;
343343

344344
hisi_ptt->trace_irq = pci_irq_vector(pdev, HISI_PTT_TRACE_DMA_IRQ);
345-
ret = devm_request_threaded_irq(&pdev->dev, hisi_ptt->trace_irq,
346-
NULL, hisi_ptt_isr, 0,
347-
DRV_NAME, hisi_ptt);
345+
ret = devm_request_irq(&pdev->dev, hisi_ptt->trace_irq, hisi_ptt_isr,
346+
IRQF_NOBALANCING | IRQF_NO_THREAD, DRV_NAME,
347+
hisi_ptt);
348348
if (ret) {
349349
pci_err(pdev, "failed to request irq %d, ret = %d\n",
350350
hisi_ptt->trace_irq, ret);

0 commit comments

Comments
 (0)