Skip to content

Commit e13f7e9

Browse files
author
Thomas Zimmermann
committed
drm/vmwgfx: Remove initialization of connector status
Remove the connector-status initialization from several of vmwgfx's functions. It is not required by the driver or DRM helpers. DRM initializes the connector to unknown status in __drm_connector_init() and reads the physical status when DRM clients or the user needs the information, or if it detects/polls a change to the status. Signed-off-by: Thomas Zimmermann <[email protected]> Reviewed-by: Zack Rusin <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 2265706 commit e13f7e9

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
479479
}
480480

481481
drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
482-
connector->status = vmw_du_connector_detect(connector, true);
483482

484483
ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
485484
DRM_MODE_ENCODER_VIRTUAL, NULL);

drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -868,7 +868,6 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit)
868868
}
869869

870870
drm_connector_helper_add(connector, &vmw_sou_connector_helper_funcs);
871-
connector->status = vmw_du_connector_detect(connector, true);
872871

873872
ret = drm_encoder_init(dev, encoder, &vmw_screen_object_encoder_funcs,
874873
DRM_MODE_ENCODER_VIRTUAL, NULL);

drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1593,7 +1593,6 @@ static int vmw_stdu_init(struct vmw_private *dev_priv, unsigned unit)
15931593
}
15941594

15951595
drm_connector_helper_add(connector, &vmw_stdu_connector_helper_funcs);
1596-
connector->status = vmw_du_connector_detect(connector, false);
15971596

15981597
ret = drm_encoder_init(dev, encoder, &vmw_stdu_encoder_funcs,
15991598
DRM_MODE_ENCODER_VIRTUAL, NULL);

0 commit comments

Comments
 (0)